[arithmetic_side_effects] Fix #11393
#11410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Centri3 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
r? clippy |
|
AFAICT this PR is superseded by the PR you just opened in the Rust repo? |
|
They are almost exactly the same to reduce any potential rebasing conflicts. So it is more like the PR in the Rust repository is the "canonical" version because of the symbols. |
|
Ok, thanks for the clarification. Then I'd rather merge the one in the Rust repo. I don't want to do a whole sync dance (over 3 weeks) around this fix. Closing as superseded by rust-lang/rust#115415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11395 tried to fix #11393 but it actually didn't due to an oversight on my side. Now everything should be OK.